CT Ban Bugs

[Forgotten]

Was on Jailbreak this morning testing out the JBTB and CT ban changes, etc. I used !rageban on a random player, removed it through CT bans panel and thought everything was fine. 2 Hours later the random person I rage banned (Choccy) told me how they were perm banned on CT for no reason, went on the server and typed !isbanned Choccy and it still showed they were banned indefinitely despite deleting the ban through the CT bans page.

Not a one off bug as I tried it with NOICE at the time as well and the same thing happened.

Second bug is that using sm_change_ctban_time on a player and changing the time to something LARGER than the original banning time it will not correct itself in CT bans page.

Example: I ban user xx_420BlazerCODPlayer_xx for 30 minutes for freekilling, I reconsidered the ban because 30 minutes wasn't enough time. I used 'sm_change_ctban_time xx_420BlazerCODPlayer_xx 60' , it would change his CT ban to 60 in-game but it wouldn't show as 60 on the CT bans page.

May have to do some more testing later. Byte

[Beax]

Can confirm got perm ct banned....

[Forgotten]

Can confirm got perm ct banned....

@Sausage ^^^^^

[Beax]

2:11 PM - Sausage: oh yeah
2:11 PM - Sausage: that was my fault
2:11 PM - Sausage: i accidently rage banned you\
2:12 PM - Sausage: apologies

[Leevie]

2:11 PM - Sausage: oh yeah
2:11 PM - Sausage: that was my fault
2:11 PM - Sausage: i accidently rage banned you\
2:12 PM - Sausage: apologies

Has been unbanned. menu was still up when i was tryna switch weapons

[Byte]

Thanks for this!
Part of my edits to CT Bans need to handle people getting unbanned when they are off the server as it doesn't handle that properly.
This has now been fixed, if your ban doesn't appear here:
https://www.invexgaming.com.au/ctbans.php

Your ban will now be auto removed when you next join Jailbreak.
So people who are currently banned, simply rejoin Jailbreak and it will fix itself.

Second bug is that using sm_change_ctban_time on a player and changing the time to something LARGER than the original banning time it will not correct itself in CT bans page.

Example: I ban user xx_420BlazerCODPlayer_xx for 30 minutes for freekilling, I reconsidered the ban because 30 minutes wasn't enough time. I used 'sm_change_ctban_time xx_420BlazerCODPlayer_xx 60' , it would change his CT ban to 60 in-game but it wouldn't show as 60 on the CT bans page.

This is not a bug!
The plugin uses a local variable to store peoples CT bans and only updates the remote database if they leave the server or the map changes etc (as optimisations).
Otherwise you'd have like 30 database queries per minute for no reason.
This is why the time shown on the CT bans page may differ from in game.
For the most part this shouldn't matter, you could simply use sourcebans panel to kick them and change their CT ban or simply make them lose out on a little bit of time they've played on that map so far.
Overall not a big deal.